Use = with all long form flags with values. #125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah right, forgot about that. Only comment on this is that the single-element extend calls should be changed to append without the wrapping in a list.
Also, please add a signed-off-by line to the commit message :)
|
Signed-off-by: Pete Heist <peteheist@users.noreply.github.com>
|
Cool, hope that works... |
|
Just fixed this manually and merged to master... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, the Go pflag packages (both of them) require long form flags with values to have equals signs. This works for me, but I'm not sure of and didn't test the local_bind stuff in particular, so by all means fix or replace any of it if there's a better way. :)